瀏覽代碼

Remove usage of eval() from postprocess.py (#4571)

Remove usage of `eval()` from postprocess.py

### What problem does this PR solve?

The use of `eval()` is a potential security risk. While the use of
`eval()` is guarded and thus not a security risk normally, `assert`s
aren't run if `-O` or `-OO` is passed to the interpreter, and as such
then the guard would not apply. In any case there is no reason to use
`eval()` here at all.

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Other (please describe):

Potential security fix if somehow the passed `modul_name` could be user
controlled.
tags/v0.16.0
Mathias Panzenböck 9 月之前
父節點
當前提交
1a367664f1
沒有連結到貢獻者的電子郵件帳戶。
共有 1 個檔案被更改,包括 6 行新增5 行删除
  1. 6
    5
      deepdoc/vision/postprocess.py

+ 6
- 5
deepdoc/vision/postprocess.py 查看文件

@@ -23,7 +23,7 @@ import pyclipper


def build_post_process(config, global_config=None):
support_dict = ['DBPostProcess', 'CTCLabelDecode']
support_dict = {'DBPostProcess': DBPostProcess, 'CTCLabelDecode': CTCLabelDecode}

config = copy.deepcopy(config)
module_name = config.pop('name')
@@ -31,10 +31,11 @@ def build_post_process(config, global_config=None):
return
if global_config is not None:
config.update(global_config)
assert module_name in support_dict, Exception(
'post process only support {}'.format(support_dict))
module_class = eval(module_name)(**config)
return module_class
module_class = support_dict.get(module_name)
if module_class is None:
raise ValueError(
'post process only support {}'.format(list(support_dict)))
return module_class(**config)


class DBPostProcess(object):

Loading…
取消
儲存