You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Qiang Lee cf2173644e
Release db.session connection before workflow new thread long time operation (#21726)
4 mesi fa
..
advanced_chat chore: Simplify code logic (#21496) 4 mesi fa
agent_chat chore: Simplify code logic (#21496) 4 mesi fa
chat chore: Simplify code logic (#21496) 4 mesi fa
common feat: Persist Variables for Enhanced Debugging Workflow (#20699) 4 mesi fa
completion chore: Simplify code logic (#21496) 4 mesi fa
workflow Release db.session connection before workflow new thread long time operation (#21726) 4 mesi fa
README.md fix: some typos using typos (#11374) 11 mesi fa
__init__.py FEAT: NEW WORKFLOW ENGINE (#3160) 1 anno fa
base_app_generate_response_converter.py Introduce Plugins (#13836) 8 mesi fa
base_app_generator.py fix: implement robust file type checks to align with existing logic (#17557) 6 mesi fa
base_app_queue_manager.py Introduce Plugins (#13836) 8 mesi fa
base_app_runner.py 🐛 Fix(Gemini LLM): Support Gemini 0.2.x plugin on agent app (#20794) 4 mesi fa
message_based_app_generator.py chore: Simplify code logic (#21496) 4 mesi fa
message_based_app_queue_manager.py chore: apply pep8-naming rules for naming convention (#8261) 1 anno fa
workflow_app_runner.py feat: Persist Variables for Enhanced Debugging Workflow (#20699) 4 mesi fa

README.md

Guidelines for Database Connection Management in App Runner and Task Pipeline

Due to the presence of tasks in App Runner that require long execution times, such as LLM generation and external requests, Flask-Sqlalchemy’s strategy for database connection pooling is to allocate one connection (transaction) per request. This approach keeps a connection occupied even during non-DB tasks, leading to the inability to acquire new connections during high concurrency requests due to multiple long-running tasks.

Therefore, the database operations in App Runner and Task Pipeline must ensure connections are closed immediately after use, and it’s better to pass IDs rather than Model objects to avoid detach errors.

Examples:

  1. Creating a new record:
   app = App(id=1)
   db.session.add(app)
   db.session.commit()
   db.session.refresh(app)  # Retrieve table default values, like created_at, cached in the app object, won't affect after close
   
   # Handle non-long-running tasks or store the content of the App instance in memory (via variable assignment).
   
   db.session.close()
   
   return app.id
  1. Fetching a record from the table:
   app = db.session.query(App).filter(App.id == app_id).first()
    
   created_at = app.created_at
    
   db.session.close()
   
   # Handle tasks (include long-running).
   
  1. Updating a table field:
   app = db.session.query(App).filter(App.id == app_id).first()

   app.updated_at = time.utcnow()
   db.session.commit()
   db.session.close()

   return app_id