You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
yihong 5669cac16d
fix: some typos using typos (#11374)
11 months ago
..
advanced_chat fix: `dialogue_count` incorrect in chatflow when there's... (#11175) 11 months ago
agent_chat Fix/type-error (#11240) 11 months ago
chat Fix/type-error (#11240) 11 months ago
completion Fix/type-error (#11240) 11 months ago
workflow Fix/type-error (#11240) 11 months ago
README.md fix: some typos using typos (#11374) 11 months ago
__init__.py FEAT: NEW WORKFLOW ENGINE (#3160) 1 year ago
base_app_generate_response_converter.py Fix/type-error (#11240) 11 months ago
base_app_generator.py fix(workflow_entry): Support receive File and FileList in single step run. (#10947) 11 months ago
base_app_queue_manager.py chore: refurish python code by applying Pylint linter rules (#8322) 1 year ago
base_app_runner.py feat/enhance the multi-modal support (#8818) 1 year ago
message_based_app_generator.py chore: bump minimum supported Python version to 3.11 (#10386) 11 months ago
message_based_app_queue_manager.py chore: apply pep8-naming rules for naming convention (#8261) 1 year ago
workflow_app_runner.py Feat: upgrade variable assigner (#11285) 11 months ago

README.md

Guidelines for Database Connection Management in App Runner and Task Pipeline

Due to the presence of tasks in App Runner that require long execution times, such as LLM generation and external requests, Flask-Sqlalchemy’s strategy for database connection pooling is to allocate one connection (transaction) per request. This approach keeps a connection occupied even during non-DB tasks, leading to the inability to acquire new connections during high concurrency requests due to multiple long-running tasks.

Therefore, the database operations in App Runner and Task Pipeline must ensure connections are closed immediately after use, and it’s better to pass IDs rather than Model objects to avoid detach errors.

Examples:

  1. Creating a new record:
   app = App(id=1)
   db.session.add(app)
   db.session.commit()
   db.session.refresh(app)  # Retrieve table default values, like created_at, cached in the app object, won't affect after close
   
   # Handle non-long-running tasks or store the content of the App instance in memory (via variable assignment).
   
   db.session.close()
   
   return app.id
  1. Fetching a record from the table:
   app = db.session.query(App).filter(App.id == app_id).first()
    
   created_at = app.created_at
    
   db.session.close()
   
   # Handle tasks (include long-running).
   
  1. Updating a table field:
   app = db.session.query(App).filter(App.id == app_id).first()

   app.updated_at = time.utcnow()
   db.session.commit()
   db.session.close()

   return app_id