You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

test_email_i18n.py 20KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539
  1. """
  2. Unit tests for EmailI18nService
  3. Tests the email internationalization service with mocked dependencies
  4. following Domain-Driven Design principles.
  5. """
  6. from typing import Any
  7. from unittest.mock import MagicMock
  8. import pytest
  9. from libs.email_i18n import (
  10. EmailI18nConfig,
  11. EmailI18nService,
  12. EmailLanguage,
  13. EmailTemplate,
  14. EmailType,
  15. FlaskEmailRenderer,
  16. FlaskMailSender,
  17. create_default_email_config,
  18. get_email_i18n_service,
  19. )
  20. from services.feature_service import BrandingModel
  21. class MockEmailRenderer:
  22. """Mock implementation of EmailRenderer protocol"""
  23. def __init__(self) -> None:
  24. self.rendered_templates: list[tuple[str, dict[str, Any]]] = []
  25. def render_template(self, template_path: str, **context: Any) -> str:
  26. """Mock render_template that returns a formatted string"""
  27. self.rendered_templates.append((template_path, context))
  28. return f"<html>Rendered {template_path} with {context}</html>"
  29. class MockBrandingService:
  30. """Mock implementation of BrandingService protocol"""
  31. def __init__(self, enabled: bool = False, application_title: str = "Dify") -> None:
  32. self.enabled = enabled
  33. self.application_title = application_title
  34. def get_branding_config(self) -> BrandingModel:
  35. """Return mock branding configuration"""
  36. branding_model = MagicMock(spec=BrandingModel)
  37. branding_model.enabled = self.enabled
  38. branding_model.application_title = self.application_title
  39. return branding_model
  40. class MockEmailSender:
  41. """Mock implementation of EmailSender protocol"""
  42. def __init__(self) -> None:
  43. self.sent_emails: list[dict[str, str]] = []
  44. def send_email(self, to: str, subject: str, html_content: str) -> None:
  45. """Mock send_email that records sent emails"""
  46. self.sent_emails.append(
  47. {
  48. "to": to,
  49. "subject": subject,
  50. "html_content": html_content,
  51. }
  52. )
  53. class TestEmailI18nService:
  54. """Test cases for EmailI18nService"""
  55. @pytest.fixture
  56. def email_config(self) -> EmailI18nConfig:
  57. """Create test email configuration"""
  58. return EmailI18nConfig(
  59. templates={
  60. EmailType.RESET_PASSWORD: {
  61. EmailLanguage.EN_US: EmailTemplate(
  62. subject="Reset Your {application_title} Password",
  63. template_path="reset_password_en.html",
  64. branded_template_path="branded/reset_password_en.html",
  65. ),
  66. EmailLanguage.ZH_HANS: EmailTemplate(
  67. subject="重置您的 {application_title} 密码",
  68. template_path="reset_password_zh.html",
  69. branded_template_path="branded/reset_password_zh.html",
  70. ),
  71. },
  72. EmailType.INVITE_MEMBER: {
  73. EmailLanguage.EN_US: EmailTemplate(
  74. subject="Join {application_title} Workspace",
  75. template_path="invite_member_en.html",
  76. branded_template_path="branded/invite_member_en.html",
  77. ),
  78. },
  79. }
  80. )
  81. @pytest.fixture
  82. def mock_renderer(self) -> MockEmailRenderer:
  83. """Create mock email renderer"""
  84. return MockEmailRenderer()
  85. @pytest.fixture
  86. def mock_branding_service(self) -> MockBrandingService:
  87. """Create mock branding service"""
  88. return MockBrandingService()
  89. @pytest.fixture
  90. def mock_sender(self) -> MockEmailSender:
  91. """Create mock email sender"""
  92. return MockEmailSender()
  93. @pytest.fixture
  94. def email_service(
  95. self,
  96. email_config: EmailI18nConfig,
  97. mock_renderer: MockEmailRenderer,
  98. mock_branding_service: MockBrandingService,
  99. mock_sender: MockEmailSender,
  100. ) -> EmailI18nService:
  101. """Create EmailI18nService with mocked dependencies"""
  102. return EmailI18nService(
  103. config=email_config,
  104. renderer=mock_renderer,
  105. branding_service=mock_branding_service,
  106. sender=mock_sender,
  107. )
  108. def test_send_email_with_english_language(
  109. self,
  110. email_service: EmailI18nService,
  111. mock_renderer: MockEmailRenderer,
  112. mock_sender: MockEmailSender,
  113. ) -> None:
  114. """Test sending email with English language"""
  115. email_service.send_email(
  116. email_type=EmailType.RESET_PASSWORD,
  117. language_code="en-US",
  118. to="test@example.com",
  119. template_context={"reset_link": "https://example.com/reset"},
  120. )
  121. # Verify renderer was called with correct template
  122. assert len(mock_renderer.rendered_templates) == 1
  123. template_path, context = mock_renderer.rendered_templates[0]
  124. assert template_path == "reset_password_en.html"
  125. assert context["reset_link"] == "https://example.com/reset"
  126. assert context["branding_enabled"] is False
  127. assert context["application_title"] == "Dify"
  128. # Verify email was sent
  129. assert len(mock_sender.sent_emails) == 1
  130. sent_email = mock_sender.sent_emails[0]
  131. assert sent_email["to"] == "test@example.com"
  132. assert sent_email["subject"] == "Reset Your Dify Password"
  133. assert "reset_password_en.html" in sent_email["html_content"]
  134. def test_send_email_with_chinese_language(
  135. self,
  136. email_service: EmailI18nService,
  137. mock_sender: MockEmailSender,
  138. ) -> None:
  139. """Test sending email with Chinese language"""
  140. email_service.send_email(
  141. email_type=EmailType.RESET_PASSWORD,
  142. language_code="zh-Hans",
  143. to="test@example.com",
  144. template_context={"reset_link": "https://example.com/reset"},
  145. )
  146. # Verify email was sent with Chinese subject
  147. assert len(mock_sender.sent_emails) == 1
  148. sent_email = mock_sender.sent_emails[0]
  149. assert sent_email["subject"] == "重置您的 Dify 密码"
  150. def test_send_email_with_branding_enabled(
  151. self,
  152. email_config: EmailI18nConfig,
  153. mock_renderer: MockEmailRenderer,
  154. mock_sender: MockEmailSender,
  155. ) -> None:
  156. """Test sending email with branding enabled"""
  157. # Create branding service with branding enabled
  158. branding_service = MockBrandingService(enabled=True, application_title="MyApp")
  159. email_service = EmailI18nService(
  160. config=email_config,
  161. renderer=mock_renderer,
  162. branding_service=branding_service,
  163. sender=mock_sender,
  164. )
  165. email_service.send_email(
  166. email_type=EmailType.RESET_PASSWORD,
  167. language_code="en-US",
  168. to="test@example.com",
  169. )
  170. # Verify branded template was used
  171. assert len(mock_renderer.rendered_templates) == 1
  172. template_path, context = mock_renderer.rendered_templates[0]
  173. assert template_path == "branded/reset_password_en.html"
  174. assert context["branding_enabled"] is True
  175. assert context["application_title"] == "MyApp"
  176. # Verify subject includes custom application title
  177. assert len(mock_sender.sent_emails) == 1
  178. sent_email = mock_sender.sent_emails[0]
  179. assert sent_email["subject"] == "Reset Your MyApp Password"
  180. def test_send_email_with_language_fallback(
  181. self,
  182. email_service: EmailI18nService,
  183. mock_sender: MockEmailSender,
  184. ) -> None:
  185. """Test language fallback to English when requested language not available"""
  186. # Request invite member in Chinese (not configured)
  187. email_service.send_email(
  188. email_type=EmailType.INVITE_MEMBER,
  189. language_code="zh-Hans",
  190. to="test@example.com",
  191. )
  192. # Should fall back to English
  193. assert len(mock_sender.sent_emails) == 1
  194. sent_email = mock_sender.sent_emails[0]
  195. assert sent_email["subject"] == "Join Dify Workspace"
  196. def test_send_email_with_unknown_language_code(
  197. self,
  198. email_service: EmailI18nService,
  199. mock_sender: MockEmailSender,
  200. ) -> None:
  201. """Test unknown language code falls back to English"""
  202. email_service.send_email(
  203. email_type=EmailType.RESET_PASSWORD,
  204. language_code="fr-FR", # French not configured
  205. to="test@example.com",
  206. )
  207. # Should use English
  208. assert len(mock_sender.sent_emails) == 1
  209. sent_email = mock_sender.sent_emails[0]
  210. assert sent_email["subject"] == "Reset Your Dify Password"
  211. def test_send_change_email_old_phase(
  212. self,
  213. email_config: EmailI18nConfig,
  214. mock_renderer: MockEmailRenderer,
  215. mock_sender: MockEmailSender,
  216. mock_branding_service: MockBrandingService,
  217. ) -> None:
  218. """Test sending change email for old email verification"""
  219. # Add change email templates to config
  220. email_config.templates[EmailType.CHANGE_EMAIL_OLD] = {
  221. EmailLanguage.EN_US: EmailTemplate(
  222. subject="Verify your current email",
  223. template_path="change_email_old_en.html",
  224. branded_template_path="branded/change_email_old_en.html",
  225. ),
  226. }
  227. email_service = EmailI18nService(
  228. config=email_config,
  229. renderer=mock_renderer,
  230. branding_service=mock_branding_service,
  231. sender=mock_sender,
  232. )
  233. email_service.send_change_email(
  234. language_code="en-US",
  235. to="old@example.com",
  236. code="123456",
  237. phase="old_email",
  238. )
  239. # Verify correct template and context
  240. assert len(mock_renderer.rendered_templates) == 1
  241. template_path, context = mock_renderer.rendered_templates[0]
  242. assert template_path == "change_email_old_en.html"
  243. assert context["to"] == "old@example.com"
  244. assert context["code"] == "123456"
  245. def test_send_change_email_new_phase(
  246. self,
  247. email_config: EmailI18nConfig,
  248. mock_renderer: MockEmailRenderer,
  249. mock_sender: MockEmailSender,
  250. mock_branding_service: MockBrandingService,
  251. ) -> None:
  252. """Test sending change email for new email verification"""
  253. # Add change email templates to config
  254. email_config.templates[EmailType.CHANGE_EMAIL_NEW] = {
  255. EmailLanguage.EN_US: EmailTemplate(
  256. subject="Verify your new email",
  257. template_path="change_email_new_en.html",
  258. branded_template_path="branded/change_email_new_en.html",
  259. ),
  260. }
  261. email_service = EmailI18nService(
  262. config=email_config,
  263. renderer=mock_renderer,
  264. branding_service=mock_branding_service,
  265. sender=mock_sender,
  266. )
  267. email_service.send_change_email(
  268. language_code="en-US",
  269. to="new@example.com",
  270. code="654321",
  271. phase="new_email",
  272. )
  273. # Verify correct template and context
  274. assert len(mock_renderer.rendered_templates) == 1
  275. template_path, context = mock_renderer.rendered_templates[0]
  276. assert template_path == "change_email_new_en.html"
  277. assert context["to"] == "new@example.com"
  278. assert context["code"] == "654321"
  279. def test_send_change_email_invalid_phase(
  280. self,
  281. email_service: EmailI18nService,
  282. ) -> None:
  283. """Test sending change email with invalid phase raises error"""
  284. with pytest.raises(ValueError, match="Invalid phase: invalid_phase"):
  285. email_service.send_change_email(
  286. language_code="en-US",
  287. to="test@example.com",
  288. code="123456",
  289. phase="invalid_phase",
  290. )
  291. def test_send_raw_email_single_recipient(
  292. self,
  293. email_service: EmailI18nService,
  294. mock_sender: MockEmailSender,
  295. ) -> None:
  296. """Test sending raw email to single recipient"""
  297. email_service.send_raw_email(
  298. to="test@example.com",
  299. subject="Test Subject",
  300. html_content="<html>Test Content</html>",
  301. )
  302. assert len(mock_sender.sent_emails) == 1
  303. sent_email = mock_sender.sent_emails[0]
  304. assert sent_email["to"] == "test@example.com"
  305. assert sent_email["subject"] == "Test Subject"
  306. assert sent_email["html_content"] == "<html>Test Content</html>"
  307. def test_send_raw_email_multiple_recipients(
  308. self,
  309. email_service: EmailI18nService,
  310. mock_sender: MockEmailSender,
  311. ) -> None:
  312. """Test sending raw email to multiple recipients"""
  313. recipients = ["user1@example.com", "user2@example.com", "user3@example.com"]
  314. email_service.send_raw_email(
  315. to=recipients,
  316. subject="Test Subject",
  317. html_content="<html>Test Content</html>",
  318. )
  319. # Should send individual emails to each recipient
  320. assert len(mock_sender.sent_emails) == 3
  321. for i, recipient in enumerate(recipients):
  322. sent_email = mock_sender.sent_emails[i]
  323. assert sent_email["to"] == recipient
  324. assert sent_email["subject"] == "Test Subject"
  325. assert sent_email["html_content"] == "<html>Test Content</html>"
  326. def test_get_template_missing_email_type(
  327. self,
  328. email_config: EmailI18nConfig,
  329. ) -> None:
  330. """Test getting template for missing email type raises error"""
  331. with pytest.raises(ValueError, match="No templates configured for email type"):
  332. email_config.get_template(EmailType.EMAIL_CODE_LOGIN, EmailLanguage.EN_US)
  333. def test_get_template_missing_language_and_english(
  334. self,
  335. email_config: EmailI18nConfig,
  336. ) -> None:
  337. """Test error when neither requested language nor English fallback exists"""
  338. # Add template without English fallback
  339. email_config.templates[EmailType.EMAIL_CODE_LOGIN] = {
  340. EmailLanguage.ZH_HANS: EmailTemplate(
  341. subject="Test",
  342. template_path="test.html",
  343. branded_template_path="branded/test.html",
  344. ),
  345. }
  346. with pytest.raises(ValueError, match="No template found for"):
  347. # Request a language that doesn't exist and no English fallback
  348. email_config.get_template(EmailType.EMAIL_CODE_LOGIN, EmailLanguage.EN_US)
  349. def test_subject_templating_with_variables(
  350. self,
  351. email_config: EmailI18nConfig,
  352. mock_renderer: MockEmailRenderer,
  353. mock_sender: MockEmailSender,
  354. mock_branding_service: MockBrandingService,
  355. ) -> None:
  356. """Test subject templating with custom variables"""
  357. # Add template with variable in subject
  358. email_config.templates[EmailType.OWNER_TRANSFER_NEW_NOTIFY] = {
  359. EmailLanguage.EN_US: EmailTemplate(
  360. subject="You are now the owner of {WorkspaceName}",
  361. template_path="owner_transfer_en.html",
  362. branded_template_path="branded/owner_transfer_en.html",
  363. ),
  364. }
  365. email_service = EmailI18nService(
  366. config=email_config,
  367. renderer=mock_renderer,
  368. branding_service=mock_branding_service,
  369. sender=mock_sender,
  370. )
  371. email_service.send_email(
  372. email_type=EmailType.OWNER_TRANSFER_NEW_NOTIFY,
  373. language_code="en-US",
  374. to="test@example.com",
  375. template_context={"WorkspaceName": "My Workspace"},
  376. )
  377. # Verify subject was templated correctly
  378. assert len(mock_sender.sent_emails) == 1
  379. sent_email = mock_sender.sent_emails[0]
  380. assert sent_email["subject"] == "You are now the owner of My Workspace"
  381. def test_email_language_from_language_code(self) -> None:
  382. """Test EmailLanguage.from_language_code method"""
  383. assert EmailLanguage.from_language_code("zh-Hans") == EmailLanguage.ZH_HANS
  384. assert EmailLanguage.from_language_code("en-US") == EmailLanguage.EN_US
  385. assert EmailLanguage.from_language_code("fr-FR") == EmailLanguage.EN_US # Fallback
  386. assert EmailLanguage.from_language_code("unknown") == EmailLanguage.EN_US # Fallback
  387. class TestEmailI18nIntegration:
  388. """Integration tests for email i18n components"""
  389. def test_create_default_email_config(self) -> None:
  390. """Test creating default email configuration"""
  391. config = create_default_email_config()
  392. # Verify key email types have at least English template
  393. expected_types = [
  394. EmailType.RESET_PASSWORD,
  395. EmailType.INVITE_MEMBER,
  396. EmailType.EMAIL_CODE_LOGIN,
  397. EmailType.CHANGE_EMAIL_OLD,
  398. EmailType.CHANGE_EMAIL_NEW,
  399. EmailType.OWNER_TRANSFER_CONFIRM,
  400. EmailType.OWNER_TRANSFER_OLD_NOTIFY,
  401. EmailType.OWNER_TRANSFER_NEW_NOTIFY,
  402. EmailType.ACCOUNT_DELETION_SUCCESS,
  403. EmailType.ACCOUNT_DELETION_VERIFICATION,
  404. EmailType.QUEUE_MONITOR_ALERT,
  405. EmailType.DOCUMENT_CLEAN_NOTIFY,
  406. ]
  407. for email_type in expected_types:
  408. assert email_type in config.templates
  409. assert EmailLanguage.EN_US in config.templates[email_type]
  410. # Verify some have Chinese translations
  411. assert EmailLanguage.ZH_HANS in config.templates[EmailType.RESET_PASSWORD]
  412. assert EmailLanguage.ZH_HANS in config.templates[EmailType.INVITE_MEMBER]
  413. def test_get_email_i18n_service(self) -> None:
  414. """Test getting global email i18n service instance"""
  415. service1 = get_email_i18n_service()
  416. service2 = get_email_i18n_service()
  417. # Should return the same instance
  418. assert service1 is service2
  419. def test_flask_email_renderer(self) -> None:
  420. """Test FlaskEmailRenderer implementation"""
  421. renderer = FlaskEmailRenderer()
  422. # Should raise TemplateNotFound when template doesn't exist
  423. from jinja2.exceptions import TemplateNotFound
  424. with pytest.raises(TemplateNotFound):
  425. renderer.render_template("test.html", foo="bar")
  426. def test_flask_mail_sender_not_initialized(self) -> None:
  427. """Test FlaskMailSender when mail is not initialized"""
  428. sender = FlaskMailSender()
  429. # Mock mail.is_inited() to return False
  430. import libs.email_i18n
  431. original_mail = libs.email_i18n.mail
  432. mock_mail = MagicMock()
  433. mock_mail.is_inited.return_value = False
  434. libs.email_i18n.mail = mock_mail
  435. try:
  436. # Should not send email when mail is not initialized
  437. sender.send_email("test@example.com", "Subject", "<html>Content</html>")
  438. mock_mail.send.assert_not_called()
  439. finally:
  440. # Restore original mail
  441. libs.email_i18n.mail = original_mail
  442. def test_flask_mail_sender_initialized(self) -> None:
  443. """Test FlaskMailSender when mail is initialized"""
  444. sender = FlaskMailSender()
  445. # Mock mail.is_inited() to return True
  446. import libs.email_i18n
  447. original_mail = libs.email_i18n.mail
  448. mock_mail = MagicMock()
  449. mock_mail.is_inited.return_value = True
  450. libs.email_i18n.mail = mock_mail
  451. try:
  452. # Should send email when mail is initialized
  453. sender.send_email("test@example.com", "Subject", "<html>Content</html>")
  454. mock_mail.send.assert_called_once_with(
  455. to="test@example.com",
  456. subject="Subject",
  457. html="<html>Content</html>",
  458. )
  459. finally:
  460. # Restore original mail
  461. libs.email_i18n.mail = original_mail