Explorar el Código

refactor: simplify success response in dataset API endpoints by returning status code 204 directly (#19685)

tags/1.4.0
GuanMu hace 5 meses
padre
commit
17b929124f
No account linked to committer's email address

+ 1
- 1
api/controllers/service_api/dataset/dataset.py Ver fichero

try: try:
if DatasetService.delete_dataset(dataset_id_str, current_user): if DatasetService.delete_dataset(dataset_id_str, current_user):
DatasetPermissionService.clear_partial_member_list(dataset_id_str) DatasetPermissionService.clear_partial_member_list(dataset_id_str)
return {"result": "success"}, 204
return 204
else: else:
raise NotFound("Dataset not found.") raise NotFound("Dataset not found.")
except services.errors.dataset.DatasetInUseError: except services.errors.dataset.DatasetInUseError:

+ 1
- 1
api/controllers/service_api/dataset/document.py Ver fichero

except services.errors.document.DocumentIndexingError: except services.errors.document.DocumentIndexingError:
raise DocumentIndexingError("Cannot delete document during indexing.") raise DocumentIndexingError("Cannot delete document during indexing.")


return {"result": "success"}, 204
return 204




class DocumentListApi(DatasetApiResource): class DocumentListApi(DatasetApiResource):

+ 2
- 2
api/controllers/service_api/dataset/segment.py Ver fichero

if not segment: if not segment:
raise NotFound("Segment not found.") raise NotFound("Segment not found.")
SegmentService.delete_segment(segment, document, dataset) SegmentService.delete_segment(segment, document, dataset)
return {"result": "success"}, 204
return 204


@cloud_edition_billing_resource_check("vector_space", "dataset") @cloud_edition_billing_resource_check("vector_space", "dataset")
def post(self, tenant_id, dataset_id, document_id, segment_id): def post(self, tenant_id, dataset_id, document_id, segment_id):
except ChildChunkDeleteIndexServiceError as e: except ChildChunkDeleteIndexServiceError as e:
raise ChildChunkDeleteIndexError(str(e)) raise ChildChunkDeleteIndexError(str(e))


return {"result": "success"}, 204
return 204


@cloud_edition_billing_resource_check("vector_space", "dataset") @cloud_edition_billing_resource_check("vector_space", "dataset")
@cloud_edition_billing_knowledge_limit_check("add_segment", "dataset") @cloud_edition_billing_knowledge_limit_check("add_segment", "dataset")

Cargando…
Cancelar
Guardar